Full factorisation new name

[Raphael-Tresor]

Changes

src/node.jl : FullFactorisation replaced by BetheFactorisation and FullFactorisation become depricated and an alias for BetheFactorisation.
test/node_tests.jl : duplicate basic test of FullFactorisation with BetheFactorisation.

[wouterwln]

I'd prefer FullJoint over FullJoin, since we're modeling a full joint probability distribution over all interfaces in a node.

[bvdmitri]

Thank you for working on this @Raphael-Tresor ! A couple of thoughts

• After you're done with the changes, you should call make format in the terminal in the package's folder to automatically adjust the formatting in the files.
• I would probably also use the @deprecate_binding macro in Julia, see more info here
• Regarding the name I find the suggestion from @wouterwln good - FullJoint
• If we deprecate the binding its better to go all examples and documentation in RxInfer.jl repo and change the default to FullJoin(t). But that can be a separate issue

[codecov]

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 62.34%. Comparing base (cb80974) to head (b38bdfe).
Report is 2 commits behind head on main.

Files	Patch %	Lines
src/nodes/mixture.jl	0.00%	5 Missing ⚠️
src/constraints/specifications/factorisation.jl	0.00%	3 Missing ⚠️
src/constraints/specifications/form.jl	0.00%	2 Missing ⚠️
src/constraints/specifications/constraints.jl	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   62.40%   62.34%   -0.07%     
==========================================
  Files         183      183              
  Lines        5940     5940              
==========================================
- Hits         3707     3703       -4     
- Misses       2233     2237       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bvdmitri]

Very nice @Raphael-Tresor , I spotted a couple of typos. The rest seems fine

[Raphael-Tresor]

Very nice @Raphael-Tresor , I spotted a couple of typos. The rest seems fine

Thanks for the review @bvdmitri , I committed your corrections.

[bvdmitri]

Thanks @Raphael-Tresor !