Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguity error for * between Diagonal and StandardBasisVector #349

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

bvdmitri
Copy link
Member

This PR fixes #348

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 64.28% and project coverage change: -1.03% ⚠️

Comparison is base (a8e6f94) 67.61% compared to head (135124d) 66.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   67.61%   66.59%   -1.03%     
==========================================
  Files         210      210              
  Lines        7686     7337     -349     
==========================================
- Hits         5197     4886     -311     
+ Misses       2489     2451      -38     
Files Changed Coverage Δ
src/helpers/algebra/standard_basis_vector.jl 67.58% <64.28%> (+0.23%) ⬆️

... and 75 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvdmitri bvdmitri merged commit 3ad37f7 into master Sep 11, 2023
10 of 12 checks passed
@bvdmitri bvdmitri deleted the dev-fix-348 branch September 11, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants