Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow returning addons from the @call_rule #346

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

bvdmitri
Copy link
Member

@bvdmitri bvdmitri commented Sep 1, 2023

This PR fixes #332

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: -0.87% ⚠️

Comparison is base (7eee68b) 67.49% compared to head (5160db4) 66.63%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   67.49%   66.63%   -0.87%     
==========================================
  Files         210      210              
  Lines        7685     7348     -337     
==========================================
- Hits         5187     4896     -291     
+ Misses       2498     2452      -46     
Files Changed Coverage Δ
src/rule.jl 92.78% <94.11%> (+0.05%) ⬆️

... and 76 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvdmitri bvdmitri merged commit a8e6f94 into master Sep 1, 2023
11 of 12 checks passed
@bvdmitri bvdmitri deleted the dev-call-rule-addons branch September 1, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@call_rule does not play nicely with addons
2 participants