Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kernel GCV node #285

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Remove Kernel GCV node #285

merged 2 commits into from
Mar 2, 2023

Conversation

albertpod
Copy link
Member

This PR is intended to clean up ReactiveMP.jl slightly.

KernelGCV is a very specific "entity," largely untested.
Also, I doubt the rules are compatible with the actual ReactiveMP API.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.17 🎉

Comparison is base (5d2f840) 62.54% compared to head (57ef050) 62.72%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   62.54%   62.72%   +0.17%     
==========================================
  Files         199      194       -5     
  Lines        7385     7364      -21     
==========================================
  Hits         4619     4619              
+ Misses       2766     2745      -21     
Impacted Files Coverage Δ
src/ReactiveMP.jl 75.86% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@albertpod albertpod merged commit 026dad1 into master Mar 2, 2023
@albertpod albertpod deleted the rm-kernel-gcv branch March 2, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants