Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ReactiveMP.sampletype #229

Merged
merged 18 commits into from
Jan 27, 2023
Merged

feat: add ReactiveMP.sampletype #229

merged 18 commits into from
Jan 27, 2023

Conversation

Nimrais
Copy link
Contributor

@Nimrais Nimrais commented Oct 26, 2022

This PR is solving the ambiguity issue of the eltype inside ReactiveMP.

@Nimrais Nimrais requested a review from bvdmitri November 3, 2022 15:08
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Base: 61.61% // Head: 61.64% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (da38540) compared to base (f9d83ac).
Patch coverage: 85.71% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   61.61%   61.64%   +0.02%     
==========================================
  Files         194      194              
  Lines        7183     7206      +23     
==========================================
+ Hits         4426     4442      +16     
- Misses       2757     2764       +7     
Impacted Files Coverage Δ
src/distributions/gamma_shape_rate.jl 82.50% <42.85%> (-8.68%) ⬇️
src/distributions/sample_list.jl 91.29% <57.14%> (-0.55%) ⬇️
src/distributions.jl 71.11% <100.00%> (+6.24%) ⬆️
src/distributions/beta.jl 93.33% <100.00%> (ø)
src/distributions/gamma.jl 91.04% <100.00%> (ø)
src/distributions/matrix_dirichlet.jl 93.33% <100.00%> (ø)
src/distributions/normal.jl 89.93% <100.00%> (ø)
src/distributions/pointmass.jl 88.88% <100.00%> (+0.13%) ⬆️
src/nodes/mv_normal_mean_covariance.jl 100.00% <100.00%> (ø)
src/nodes/mv_normal_mean_precision.jl 100.00% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bvdmitri bvdmitri merged commit dc883c1 into master Jan 27, 2023
@bvdmitri bvdmitri deleted the sampletype branch January 27, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants