feat: verify receive address on BitBox02 hardware #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #599
Adds a button to verify address on device screen when the account is a BitBox02 imported account
The functionality is pretty simple, but please let me know if there are any issues with how I did it
Also if there are any issues with the UI and styling, I reused your "Eye" icon, which maybe you'll want to change to avoid confusion, let me know if you'd like a different icon for this, and what kind
The CSS should only change when this button appears, so those changes shouldn't touch anything else
Not sure how you handle your CHANGELOGS, let me know if I should add the feature somewhere
Looks like this:
Would be nice to maybe add the button in a couple more places that are easier to access, but I'd like your feedback on that first
On the main screen next to the copy button when using the BitBox:
As an additional row or button on the Address Detail screen:
