Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] add fal component. #5662

Merged
merged 6 commits into from
Mar 15, 2022
Merged

[update] add fal component. #5662

merged 6 commits into from
Mar 15, 2022

Conversation

liukangcc
Copy link
Member

@liukangcc liukangcc commented Mar 11, 2022

拉取/合并请求描述:(PR description)

[
tested on the art-pi board

image

]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

mysterywolf commented Mar 11, 2022

FAL的版本号还需要保留吗?FAL_SW_VERSION
@armink 龙哥麻烦看一眼吧

components/fal/Kconfig Outdated Show resolved Hide resolved
components/fal/SConscript Outdated Show resolved Hide resolved
components/fal/SConscript Outdated Show resolved Hide resolved
components/fal/inc/fal_def.h Outdated Show resolved Hide resolved
components/fal/inc/fal_def.h Outdated Show resolved Hide resolved
components/fal/inc/fal_def.h Show resolved Hide resolved
components/fal/Kconfig Outdated Show resolved Hide resolved
@armink
Copy link
Member

armink commented Mar 12, 2022

AL的版本号还需要保留吗?FAL_SW_VERSION

是可以去掉的

@mysterywolf
Copy link
Member

FAL_SW_VERSION @liukangcc 版本号宏可以干掉了

@liukangcc
Copy link
Member Author

FAL_SW_VERSION @liukangcc 版本号宏可以干掉了

image
这些 都删掉么

@mysterywolf mysterywolf added the +1 Agree +1 label Mar 15, 2022
@mysterywolf
Copy link
Member

related: RT-Thread/packages#1209

@Guozhanxin Guozhanxin merged commit 75a7cb6 into RT-Thread:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants