Develop stream 2024-07-01 #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samjwu The clang format CI step seems to not handle external PRs properly, I think this might also be happening in other repositories. |
Naraenda
requested review from
a team,
stanleytsang-amd,
umfranzw,
RobsonRLemos and
lawruble13
as code owners
|
@stanleytsang-amd Let me know if I should squash the commits into their respective merge commits. |
Run git fetch origin develop
|
Naraenda
force-pushed
the
develop_stream_20240701
branch
from
4ccc1c5
to
b6c8731
Compare
|
Rebased to get the clang-format ci fixes. |
rocm-docs-core distributes headers and stylesheets for doxygen for embedding its HTML output into sphinx. These mostly fix dark-theme and other minor visual issues when doxygen output is used this way.
docs(api reference): rocm-docs-core headers and stylesheets in doxyfile See merge request amd/libraries/rocRAND!326
…ream' Improve accuracy of Poisson histogram test Closes ROCm#240 See merge request amd/libraries/rocRAND!327
…ns.hpp and src/rng/device_engines.hpp
…tream' Resolve "Remove deprecated internal headers" Closes ROCm#341 See merge request amd/libraries/rocRAND!330
AMDGPU_TARGETS doesn't pick up updates correctly (needs cache clean) whereas GPU_TARGETS does. Every other doc and CI too refers to GPU_TARGETS.
Resolve "Some host generators might not support large sizes due to min / max" See merge request amd/libraries/rocRAND!329
Recent changes required for HIP graph support added a new path with approximation of Poisson with normal distribution when lambda is large. However, the decision whether to use the alias/CDF methods or the approximation is made in the kernel for every generated value even though lambda is the same. This change moves it to host side: depending on lambda the kernel is launched with one of two distributions (poisson_distribution or poisson_distribution_huge).
Resolve "Document HIP Graph support" Closes ROCm#360 See merge request amd/libraries/rocRAND!335
…p_stream' Fix performance regression of Poisson distribution introduced by HIP graph support Closes ROCm#366 See merge request amd/libraries/rocRAND!336
hipcc from ROCm 6.2 does not add `-mllvm -amdgpu-early-inline-all=true -mllvm -amdgpu-function-calls=false` by default.
Improve performance on ROCm 6.2 See merge request amd/libraries/rocRAND!337
…as the former is unintuitive
ci(.gitlab-ci.yml): replace 'ROCM_PATH' variable with 'env:HIP_PATH' as the former is unintuitive See merge request amd/libraries/rocRAND!339
Remove unused FindTestU01.cmake See merge request amd/libraries/rocRAND!342
…te' into 'develop_stream' Resolve "Add check for nullptr data when calling host generate." Closes ROCm#369 See merge request amd/libraries/rocRAND!341
operator >> has higher precedence than operator &. This bug causes very low quality in crush tests.
…ream' Fix threefry2x64 and threefry4x64 Closes ROCm#371 See merge request amd/libraries/rocRAND!343
Naraenda
force-pushed
the
develop_stream_20240701
branch
from
b6c8731
to
d4f972c
Compare
|
Rebased and added threefry fixes by @ex-rzr |
umfranzw
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
I've finished working my way through this one, and I think it looks good. All our CI checks are also passing now.
@stanleytsang-amd if you have no objections, I'm ok with this one going in.
stanleytsang-amd
requested changes
Aug 7, 2024
stanleytsang-amd
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings various updates, intended for ROCm 6.3.
It contains the following merge commits:
GPU_TARGETSinstead ofAMDGPU_TARGETThis PR does not contain fixes for the recent performance regressions, we'll either add them here or create a new PR for those.