Programming interface #3532
Draft
Programming interface #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neon60
force-pushed
the
programming_interface
branch
2 times, most recently
from
e8ce33e
to
0c1132d
Compare
- Add clr surface functions - Update based on review comments - Fix clocks
Correct broken reference
Update doc reqs Update requirements files Update documentation requirements Fix
- Move md files to rst - Impl editorial suggestions from @lpaoletti - External PR feedbacks from HIP team
neon60
force-pushed
the
programming_interface
branch
from
7f74c72
to
c749260
Compare
neon60
force-pushed
the
programming_interface
branch
from
568a8c5
to
441730f
Compare
Update surface functions in cpp language extensions Update doxyfile and fix the function naming Change to new clr branch Fix white space characthers
neon60
force-pushed
the
programming_interface
branch
from
0e9eafd
to
6c5b4a0
Compare
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
- Replace title case with sentence case - Fix SAXPY tutorial grammar issue
neon60
force-pushed
the
programming_interface
branch
from
d19bb62
to
d1af506
Compare
neon60
force-pushed
the
programming_interface
branch
2 times, most recently
from
d9b1cb2
to
1d02157
Compare
Open
neon60
force-pushed
the
programming_interface
branch
2 times, most recently
from
d1b9a3e
to
8d4d17b
Compare
neon60
force-pushed
the
programming_interface
branch
from
8d4d17b
to
7b45147
Compare
MKKnorr
reviewed
Sep 6, 2024
docs/understand/hip_runtime_api.rst
Outdated
Comment on lines
141
to
140
| Read-only storage visible to all threads in a given grid. It is a limited | ||
| segment of global with queryable size. |
There was a problem hiding this comment.
I think this should highlight the differences to global memory, i.e. (possibly) different caching, and performance recommendations.
Also I'm not sure if it's really a segment of global memory (which is a logical partition), but rather part of device memory (as in physically located there)
Suggested change
| Read-only storage visible to all threads in a given grid. It is a limited | |
| segment of global with queryable size. | |
| Read-only storage visible to all threadson a given device. It is a limited | |
| segment backed by device memory with queryable size. It needs to be set by the host before kernel execution. | |
| Constant memory provides the best performance benefit when all threads within a warp access the same address. |
There was a problem hiding this comment.
Maybe here given grid was better. Updated. Let's discuss offline.
docs/understand/hip_runtime_api.rst
Outdated
| Unified Memory is a single memory address space accessible from any processor | ||
| within a system. This setup simplifies memory management processes and enables | ||
| applications to allocate data that can be read or written by code running on | ||
| either CPUs or GPUs. The Unified memory model is shown in the following figure. |
There was a problem hiding this comment.
There is no figure here :)
Also, should the performance implications be mentioned here?
MKKnorr
reviewed
Sep 6, 2024
neon60
force-pushed
the
programming_interface
branch
from
da9be97
to
f2228e1
Compare
neon60
force-pushed
the
programming_interface
branch
3 times, most recently
from
5e25f0a
to
77cd365
Compare
neon60
force-pushed
the
programming_interface
branch
from
cb7cb3d
to
7ea85a1
Compare
neon60
force-pushed
the
docs/develop
branch
from
98f9599
to
73814d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@randyh62 The programming interface currently.