Check workspace folder with both original and real path #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2021
ElianHugh
pushed a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #393
Closes #628
Closes #825
This PR make
isFromWorkspacealso check if the session requests come from the real path of the workspace folders if they are symlinks so that session watcher could work with symlink workspace folders.How can I check this pull request?
test.test2to that folder.test2in vscode and create an R file to activate vscode-R.getwd()shows its working directory istestinstead oftest2.test2istest, so the session will be attached.View(mtcars),plot(rnorm(100)), etc.