Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser handles file:// #817

Merged
merged 2 commits into from
Oct 11, 2021
Merged

browser handles file:// #817

merged 2 commits into from
Oct 11, 2021

Conversation

renkun-ken
Copy link
Member

@renkun-ken renkun-ken commented Oct 10, 2021

What problem did you solve?

Closes #812

show_browser now handles file:// input so that the file could be open by system.

How can I check this pull request?

Create a file, start R and run .vsc.browser("file:///path/to/the/file.abc").

R/session/vsc.R Outdated Show resolved Hide resolved
@renkun-ken renkun-ken merged commit a1f155f into master Oct 11, 2021
@renkun-ken renkun-ken deleted the browse-file branch March 5, 2022 17:46
ElianHugh pushed a commit to ElianHugh/vscode-R that referenced this pull request May 12, 2022
* browser handles file://

* No need to check before sub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browseURL() doesn't work with file:// URLs
2 participants