R Markdown Enhancements (Knit Manager) #765

ElianHugh · 2021-08-26T14:06:02Z

Enhances rendering R Markdown documents. Specifically:

background knitting (with progress bar)
set knit working directory
Smart knit button, use custom knit functions + rmarkdown::render_site where appropriate

Screenshots

"Smart" Knit Button

Custom Knit

R Markdown Site

- getKnitParams is only used by knitmanager, so should be a private method on it

Fix bug where knitDir could not be resolved when refreshing a preview

- Remove auto-generated package lock - Remove console.log from previous debugging

renkun-ken · 2021-08-30T07:01:32Z

Always fail to start debugging. The following error occurs on extension activation:

Activating extension 'Ikuyadeu.r' failed: rmarkdown.RMarkdownPreviewManager is not a constructor.

src/rmarkdown/manager.ts

ElianHugh · 2021-08-30T09:05:16Z

Always fail to start debugging. The following error occurs on extension activation:
Activating extension 'Ikuyadeu.r' failed: rmarkdown.RMarkdownPreviewManager is not a constructor.

I suspect this is some kind of bug with TypeScript, as I had this happen until I deleted my out folder. It could also be the version of TS installed? I've updated to 4.3.5. In any case, I can't see why a wildstar import would be invalid for classes, but explicit exports would be ok

- Fixed bug where knit would error when focused on the output stream - Get rPath every knit/preview, so that rPath can be changed without restarting session

renkun-ken · 2021-08-31T05:43:49Z

as I had this happen until I deleted my out folder

This actually works nicely! Thanks!

src/rmarkdown/knit.ts

Fallback to document folder when workspace is undefined, then fallback to NULL

src/rmarkdown/knit.ts

renkun-ken

Works nicely!

LGTM

ManuelHentschel · 2021-09-03T13:34:50Z

On windows, if I set the Knit directory to the document directory, I get an error:

[VSC-R] test.Rmd process started
Erreur : '\\' inattendu(e) dans "knitr::opts_knit[['set']](root.dir = c:\\"
Ex�cution arr�t�e

[VSC-R] test.Rmd process exited with exit code 1

In the workspace root this error does not occur.

ElianHugh · 2021-09-04T05:56:35Z

On windows, if I set the Knit directory to the document directory, I get an error:
[VSC-R] test.Rmd process started
Erreur : '\\' inattendu(e) dans "knitr::opts_knit[['set']](root.dir = c:\\"
Ex�cution arr�t�e

[VSC-R] test.Rmd process exited with exit code 1
In the workspace root this error does not occur.

Argh, the path differences are the bane of my existence!! Thanks for catching that, hopefully the most recent commit fixes this?

package.json

src/rmarkdown/knit.ts

src/rmarkdown/index.ts

ManuelHentschel · 2021-09-04T09:18:14Z

Argh, the path differences are the bane of my existence!! Thanks for catching that, hopefully the most recent commit fixes this?

Can confirm that I'm not getting the error anymore

ManuelHentschel

I'm not very experienced with Rmd, but the simple examples I tried worked nicely.

Thanks for the nice work!

- Use enum type for knitDir - Use quickpick result, rather than onDidSelectItem - Refresh active preview on knitDir change - use vscode namespace - fix default config value

* background knitting (with progress bar) * set knit working directory * Smart knit button, use custom knit functions + rmarkdown::render_site where appropriate

ElianHugh and others added 8 commits August 24, 2021 01:35

initial impl. of param reading

25c6f40

Knit commands in overflow menu, use rmd params to modify knit command

85d1082

Rewrite R Markdown process spawning

8be39b0

bug fixes, refactor

3f65f08

Rearrange methods

a6215b9

- getKnitParams is only used by knitmanager, so should be a private method on it

Add paths to knit quickpick, minor renaming

a8a3ce8

Add incremental progress to knit progress

a70fb31

Display output format in progress, better check for website rmd

ee70e92

This was linked to issues Aug 26, 2021

[Feature request] Customize the Knit button #753

Closed

RMarkdown: Working directory differs between "Run chunk" and "Knit Rmd" #758

Closed

ElianHugh added the enhancement label Aug 26, 2021

ElianHugh linked an issue Aug 26, 2021 that may be closed by this pull request

Allow knit Rmd to integrate with RMarkdown's site paradigm #615

Closed

ElianHugh and others added 5 commits August 28, 2021 01:08

better handle rmarkdown::render_site

2168a40

Further improve decision on knitting as website vs as doc

657efae

Bug fix knitDir, minor changes

53aaba0

Fix bug where knitDir could not be resolved when refreshing a preview

Remove package lock, remove leftover debugging

6486e77

- Remove auto-generated package lock - Remove console.log from previous debugging

Update yarn.lock

7b02cd3

renkun-ken reviewed Aug 30, 2021

View reviewed changes

src/rmarkdown/manager.ts Outdated Show resolved Hide resolved

Bug fix, get rPath every knit

c39c613

- Fixed bug where knit would error when focused on the output stream - Get rPath every knit/preview, so that rPath can be changed without restarting session

Better support multi-root

16c0859

renkun-ken reviewed Aug 31, 2021

View reviewed changes

src/rmarkdown/knit.ts Outdated Show resolved Hide resolved

Workspace fallbacks

30a0534

Fallback to document folder when workspace is undefined, then fallback to NULL

renkun-ken reviewed Sep 1, 2021

View reviewed changes

src/rmarkdown/knit.ts Outdated Show resolved Hide resolved

ElianHugh and others added 2 commits September 2, 2021 13:12

Update knit.ts

90c9ade

Use enum

10c3950

renkun-ken approved these changes Sep 2, 2021

View reviewed changes

ElianHugh changed the title ~~[WIP] R Markdown Enhancements (Knit Manager)~~ R Markdown Enhancements (Knit Manager) Sep 2, 2021

ElianHugh marked this pull request as ready for review September 2, 2021 05:39

ElianHugh requested a review from ManuelHentschel September 2, 2021 05:39

Try to fix windows paths, add option to use old knit command

60ded36

ManuelHentschel reviewed Sep 4, 2021

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/rmarkdown/knit.ts Outdated Show resolved Hide resolved

src/rmarkdown/knit.ts Outdated Show resolved Hide resolved

src/rmarkdown/knit.ts Show resolved Hide resolved

src/rmarkdown/index.ts Show resolved Hide resolved

ManuelHentschel approved these changes Sep 4, 2021

View reviewed changes

Review changes

4e118fc

- Use enum type for knitDir - Use quickpick result, rather than onDidSelectItem - Refresh active preview on knitDir change - use vscode namespace - fix default config value

ElianHugh merged commit 9f03d55 into REditorSupport:master Sep 4, 2021

jarbet mentioned this pull request Jul 19, 2022

Add date to rmarkdown file output name when clicking "knit" #1153

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

R Markdown Enhancements (Knit Manager) #765

R Markdown Enhancements (Knit Manager) #765

ElianHugh commented Aug 26, 2021 •

edited

Loading

renkun-ken commented Aug 30, 2021

ElianHugh commented Aug 30, 2021

renkun-ken commented Aug 31, 2021

renkun-ken left a comment

ManuelHentschel commented Sep 3, 2021

ElianHugh commented Sep 4, 2021

ManuelHentschel commented Sep 4, 2021

ManuelHentschel left a comment

R Markdown Enhancements (Knit Manager) #765

R Markdown Enhancements (Knit Manager) #765

Conversation

ElianHugh commented Aug 26, 2021 • edited Loading

Screenshots

"Smart" Knit Button

Custom Knit

R Markdown Site

renkun-ken commented Aug 30, 2021

ElianHugh commented Aug 30, 2021

renkun-ken commented Aug 31, 2021

renkun-ken left a comment

Choose a reason for hiding this comment

ManuelHentschel commented Sep 3, 2021

ElianHugh commented Sep 4, 2021

ManuelHentschel commented Sep 4, 2021

ManuelHentschel left a comment

Choose a reason for hiding this comment

ElianHugh commented Aug 26, 2021 •

edited

Loading