Check conflict extension #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me! Is this the only conflicting extension that we know of? If we end up with more, in the future it could be worth putting all the 'extension checks' into a separate function/file. |
|
Yes, it is the only one we know, and I guess it is quite unlikely to have conflicts with other extensions. |
ElianHugh
pushed a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #731
Closes #482
This PR checks if
mikhail-arkhipov.ris enabled on activation. If so, a message will show and the extension panel will search "R Tools" so that it is easier for the user to disable or uninstall the extension in conflict.(If you do not have screenshot) How can I check this pull request?
mikhail-arkhipov.r.Rfile to activate bothvscode-RandR Tools.R Tools.R Toolsextension and reload window