Fix R terminal attachment when the r.rterm setting contains only the executable file name
#1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extension debugging in VSCode Also update `settings.json` and fix formatting in some files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
This PR fixes R terminal attachment when the
r.rtermsetting contains only the executable file name.It takes into account if the executable file name already contains the
.exeextension in case of thewin32platform.In addition, this PR:
launch.jsonand changesoutDirtodistin all places to fix the extension debugging in VSCode;cryptomodule from the deprecated external one;problemMatcherto thenpm watchtask (the required extensionamodio.tsl-problem-matcheris added to theextensions.json);settings.jsonfile and fixes formatting in some files;I would love to hear your thoughts and suggestions on this!
Looking forward to your review and feedback. Thanks!