Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading comments from terminal submission (#1244) #1245

Merged
merged 6 commits into from
Feb 1, 2023

Conversation

gowerc
Copy link
Contributor

@gowerc gowerc commented Oct 30, 2022

What problem did you solve?

Code removes leading comments from code submitted to terminal (issue #1244)

(If you have)Screenshot

remove_comments_screencast.webm

@gowerc
Copy link
Contributor Author

gowerc commented Oct 31, 2022

I’m now wondering if this instead should be moved to within expandselction? This current implementation would also strip leading comments off of explicitly highlighted chunks of code, though maybe that’s not an issue, I’m not too sure?

src/selection.ts Outdated Show resolved Hide resolved
Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken renkun-ken merged commit 07fa8fb into REditorSupport:master Feb 1, 2023
@gowerc
Copy link
Contributor Author

gowerc commented Feb 1, 2023

Just wanted to apologies for not getting around to finishing this off myself, we just had a baby daughter which is consuming all my spare time at the moment 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants