Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the original pattern in the ParseError for ntriples.eat() #640

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

justinccdev
Copy link

No description provided.

@joernhees
Copy link
Member

joernhees commented Jul 26, 2016

short check shows that this is totally useful:

In [4]: 'this: %s' % re.compile('foo')
Out[4]: 'this: <_sre.SRE_Pattern object at 0x10537c618>'

In [5]: 'this: %s' % re.compile('foo').pattern
Out[5]: 'this: foo'

In [6]: 'this: %r' % re.compile('foo')
Out[6]: 'this: <_sre.SRE_Pattern object at 0x10537c618>'

failing tests seem unrelated, but i'll try to fix them first...

@joernhees joernhees added bug Something isn't working enhancement New feature or request in-resolution parsing Related to a parsing. labels Jul 26, 2016
@joernhees joernhees self-assigned this Jul 26, 2016
@joernhees joernhees added this to the rdflib 4.2.2 milestone Jul 26, 2016
@justinccdev
Copy link
Author

Yeah, from a quick look it seems travis is breaking due to dependency issues. I ran the tests [1] locally and looks okay from here.

[1] http://rdflib.readthedocs.io/en/stable/developers.html#running-tests

joernhees added a commit to joernhees/rdflib that referenced this pull request Jul 27, 2016
* master:
  only run flake8 in latest py2 and py3 version
  pinning html5lib to 1.0b8 for now
  removed now unnecessary version restriction from SPARQLWrapper
  updated fuseki used in travis tests to 2.4.0
  travis updates setuptools and pip before installing
@joernhees
Copy link
Member

in that case you probably still have html5lib <= 1.0b8 installed... latest seems to have some backwards incompatible changes :(

@joernhees joernhees merged commit f06ee53 into RDFLib:master Jul 27, 2016
joernhees added a commit that referenced this pull request Jul 27, 2016
@justinccdev justinccdev deleted the output-pattern-for-debug branch July 27, 2016 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request in-resolution parsing Related to a parsing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants