Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more type-hinting for SPARQL plugin #2265

Merged
merged 4 commits into from
Mar 12, 2023
Merged

more type-hinting for SPARQL plugin #2265

merged 4 commits into from
Mar 12, 2023

Commits on Mar 12, 2023

  1. add type-hints; including minor refactor of prettify_parsetree() to i… 

    …mprove type-hinting
    @jclerman @aucampia
    jclerman authored and aucampia committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    fcec02e View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @aucampia
    aucampia committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    99d56f1 View commit details
    Browse the repository at this point in the history

  3. fix: ignore type errors

    @aucampia
    aucampia committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    77ef8cd View commit details
    Browse the repository at this point in the history

  4. fix: change IO to Union[TextIO, BinaryIO] 

    This is more accurate and eliminates type errors.
    @aucampia
    aucampia committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    eebb27f View commit details
    Browse the repository at this point in the history