Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SELECT * inside SELECT * bug #2190

Merged
merged 4 commits into from
Jan 29, 2023
Merged

Fix for SELECT * inside SELECT * bug #2190

merged 4 commits into from
Jan 29, 2023

Conversation

robons
Copy link
Contributor

@robons robons commented Dec 30, 2022

Summary of changes

Fixing use of SELECT * in sub-select within SELECT * parent query as discovered in #1722.

Now when an instance of SELECT * is encountered, the query tree/plan builder now correctly considers the projected variables of any sub-select statements when deciding which variables should be projected out.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • For changes that have a potential impact on users of this project:
    • (NA) Updated relevant documentation to avoid inaccuracies.
    • (NA) Considered adding additional documentation.
    • (NA) Considered adding an example in ./examples for new features.
    • (NA) Considered updating our changelog (CHANGELOG.md).
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

coveralls commented Dec 30, 2022

Coverage Status

Coverage: 90.66% (+0.004%) from 90.656% when pulling c72cb5f on robons:subquery-in-subquery into fbb8279 on RDFLib:main.

@aucampia aucampia requested a review from a team January 26, 2023 20:52
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @robons and apologies for the late review. The change and test looks good to me, so I'm going to merge it before Monday if there is no further feedback.

@aucampia aucampia added ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review labels Jan 26, 2023
@aucampia aucampia merged commit c5c16df into RDFLib:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPARQL Sub-query inside sub-query fails
3 participants