Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2179 incorrect headers #2183

Merged
merged 6 commits into from
Dec 24, 2022
Merged

Issue2179 incorrect headers #2183

merged 6 commits into from
Dec 24, 2022

Conversation

gitmpje
Copy link
Contributor

@gitmpje gitmpje commented Dec 17, 2022

Summary of changes

This PR solves issue 2179 "Wrong Content-Type header was sent with query GET request after a POST update request".

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

Mark van der Pas and others added 6 commits December 17, 2022 14:55
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @gitmpje, copy was not enough, it needed a deepcopy, but the test was great and you found the exact source of the problem which is very helpful.

I changed copy to deepcopy and also changed the test to run everything twice so that any issues with ordering is picked up both ways.

@aucampia aucampia requested a review from a team December 21, 2022 20:37
@aucampia
Copy link
Member

I will merge by the weekend if there are no further changes.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 90.633% when pulling 55bcf12 on gitmpje:issue2179_incorrect_headers into 0e61a7f on RDFLib:main.

@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Dec 21, 2022
@gitmpje
Copy link
Contributor Author

gitmpje commented Dec 22, 2022

@aucampia Thank you for fixing this issue more fundamentally and resolving the formatting issues. Using copy seemed to solve the issue when testing locally, but deepcopy should definitely fix it.

@aucampia aucampia merged commit 36c35a8 into RDFLib:main Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants