Issue 2164

[hsolbrig]

Summary of changes

Added a test case for issue #2164 and proposed a fix. The problem arose in line #415 in context.py, where the base URI passed to _prep_sources was overwritten in anticipation of processing inner nestings. Changed the assignment to base to new_base

[hsolbrig]

This appears to be happening because of test_localsuite.py expects the data to be located in https://rdflib.github.io/rdflib-jsonld/local-testsuite/ instead of the local testing directory. @ashleysommer - I need some advice on where to put this test. Note: I was able to pass it locally by adding the re-assignment of TC_BASE below

testsuite_dir = p.join(p.abspath(p.dirname(__file__)), "local-suite")
TC_BASE = testsuite_dir + os.sep

[coveralls]

Coverage increased (+0.0005%) to 90.633% when pulling eb0fbe0 on hsolbrig:issue_2164 into 0e61a7f on RDFLib:main.

[aucampia]

pre-commit.ci autofix

[aucampia]

This appears to be happening because of test_localsuite.py expects the data to be located in https://rdflib.github.io/rdflib-jsonld/local-testsuite/ instead of the local testing directory.

The reason this URI is used is so that there is a system neutral way of referring to tests and test content, the best reference I can find for this now is this

The home of the test suite is <http://www.w3.org/2013/TurtleTests/>.
Per RFC 3986 section 5.1.3, the base IRI for parsing each file is the
retrieval IRI for that file. For example, the tests turtle-subm-01 and
turtle-subm-27 require relative IRI resolution against a base of
<http://www.w3.org/2013/TurtleTests/turtle-subm-01.ttl> and
<http://www.w3.org/2013/TurtleTests/turtle-subm-27.ttl> respectively.

There really are no good or simple solutions to this. We had a similar problem for the SPARQL test suite and there I resorted to monkey patching:

rdflib/test/utils/sparql_checker.py

Lines 349 to 374 in 0e61a7f

	def patched_query_context_load(uri_mapper: URIMapper) -> Callable[..., Any]:
	def _patched_load(
	self: QueryContext, source: URIRef, default: bool = False, **kwargs
	) -> None:
	public_id = None
	use_source: Union[URIRef, Path] = source
	format = guess_format(use_source)
	if f"{source}".startswith(("https://", "http://")):
	use_source = uri_mapper.to_local_path(source)
	public_id = source
	if default:
	assert self.graph is not None
	self.graph.parse(use_source, format=format, publicID=public_id)
	else:
	self.dataset.parse(use_source, format=format, publicID=public_id)
	return _patched_load
	def check_query(monkeypatch: MonkeyPatch, entry: SPARQLEntry) -> None:
	assert entry.query is not None
	assert isinstance(entry.result, URIRef)
	monkeypatch.setattr(
	QueryContext, "load", patched_query_context_load(entry.uri_mapper)
	)

In this case I think what you did is fine as there is no need for system neutral references in the local-suite JSON-LD tests.

The change and tests looks fine to me otherwise. I will just do a double check tomorrow but I think it is good to merge.

[aucampia]

Okay I made a small change to instead use a file URI for TC_BASE and also added a comment to explain why, this should keep things closer to the way it was.

[aucampia]

Change looks good to me @hsolbrig - I will merge by this weekend if there is no further feedback.