-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce WGS84 DefinedNamespace #1710
Conversation
The _WGS84 namespace was introduced to the namespace package matching the convention of other namespaces. The comment style of the GEO vocabulary was mimicked for consistency. wgs84:geometry was given additional documentation because it is not a standard term in the namespace. It was included because it is used by dbpedia. The prefix 'wgs84' was adopted for the namespace so that it would not conflict with the current usage of 'geo' for GeoSPARQL.
The more commonly used prefix for wgs84 is wgspos, at least when it's [looked up](https://prefix.cc/wgspos) through sites like prefix.cc. It makes sense to use that rather than wgs84 which likely hasn't seen any use.
My best guess for a different prefix was |
For what it's worth, I've seen the prefixes See: |
Edmond Chuc commented that he'd seen the `wgs` prefix in use but not `wgspos`. He also noted that it also resolves to wgs84 at http://prefix.cc/wgs. It's shorter/cleaner and shouldn't conflict with anything
Sold me on it. I also renamed the class |
rdflib/namespace/__init__.py
Outdated
@@ -75,6 +75,7 @@ | |||
* TIME | |||
* VANN | |||
* VOID | |||
* WGS84 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* WGS84 | |
* WGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the docstring (see suggestion).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh new to reviews on github, trying to find the suggested docstring changes
I think that I made the suggested changes in 86d1773, but I'm not finding any suggested changes for the docstring. Sorry if I'm making some noob mistakes here. |
See #1710 (comment) |
Fixed it now in 0208526 |
Will merge next week, but would be good to get one more approval. |
I just changed a comment in the code indicating a Datatype that should have been a Class. Also, I've removed Regarding use of a structured literal for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rechecked after @nicholascar 's changes
The _WGS84 namespace was introduced to the namespace package matching the
convention of other namespaces. The comment style of the GEO vocabulary was
mimicked for consistency. wgs84:geometry was given additional documentation
because it is not a standard term in the namespace. It was included because it
is used by dbpedia. The prefix 'wgs84' was adopted for the namespace so that it
would not conflict with the current usage of 'geo' for GeoSPARQL.
Fixes #1709
Proposed Changes
rdflib.namespace.WGS84
wgs84
as a default prefix for the namespace