Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass url in httpclient #948

Closed
wants to merge 1 commit into from
Closed

Pass url in httpclient #948

wants to merge 1 commit into from

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Sep 3, 2024 •
edited
Loading

Description:

  • Pass url in httpclient

Checklist:

  • The Main workflow has succeeded
  • The Gatling tests have passed
  • I have logged into the portal running locally with default admin credentials
  • I have updated the README files if this change requires documentation update
  • I have commented my code, particularly in hard-to-understand areas

yatharthranjan
yatharthranjan reviewed Sep 4, 2024
View reviewed changes
radar-auth/src/main/java/org/radarbase/auth/jwks/JwksTokenVerifierLoader.kt
@@ -78,7 +78,7 @@ class JwksTokenVerifierLoader(

private val logger = LoggerFactory.getLogger(JwksTokenVerifierLoader::class.java)

private val httpClient = HttpClient(CIO).config {
private fun httpClient(url: String) = HttpClient(CIO).config {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can move this to the class property instead of converting to a function. I don't think the url will change per class instance

@pvannierop
Copy link
Collaborator

Replaced by #949

@pvannierop pvannierop closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan left review comments

@nivemaham nivemaham Awaiting requested review from nivemaham nivemaham is a code owner

@Bdegraaf1234 Bdegraaf1234 Awaiting requested review from Bdegraaf1234 Bdegraaf1234 is a code owner

@peyman-mohtashami peyman-mohtashami Awaiting requested review from peyman-mohtashami peyman-mohtashami is a code owner

@pvannierop pvannierop Awaiting requested review from pvannierop pvannierop is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpgxvii @pvannierop @yatharthranjan