Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kratos subject webhook endpoint #888

Closed
wants to merge 21 commits into from
Closed

Add kratos subject webhook endpoint #888

wants to merge 21 commits into from

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Jul 8, 2024 •
edited
Loading

Description:

  • Add kratos webhook endpoint to allow automatic creation of subjects after kratos registration
  • After subject is created, this adds back session id information such as scope, roles, to kratos id

Solves https://github.com/RADAR-base/hydra-kratos/issues/43

@mpgxvii mpgxvii marked this pull request as draft July 8, 2024 14:51
@mpgxvii mpgxvii marked this pull request as ready for review July 8, 2024 15:17
Bdegraaf1234
Bdegraaf1234 previously approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@Bdegraaf1234 Bdegraaf1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change in a suggestion but otherwise LGTM,

src/main/java/org/radarbase/management/web/rest/KratosEndpoint.kt Outdated Show resolved Hide resolved
@mpgxvii @Bdegraaf1234
Update logger factory
84b4ffb 
Co-authored-by: Bastiaan <bastiaan@thehyve.nl>
@Bdegraaf1234
Copy link
Member

Bdegraaf1234 commented Jul 31, 2024 •
edited
Loading

LGTM, ready to merge? Should we merge this to the ory feature branch?

@yatharthranjan
Copy link
Member

Hi @Bdegraaf1234, we are waiting to merge till the auth is sorted (depends on jwt and claims being added)

@Bdegraaf1234 Bdegraaf1234 marked this pull request as draft July 31, 2024 10:08
@Bdegraaf1234
Copy link
Member

Alright, converted to draft then :)

@mpgxvii mpgxvii marked this pull request as ready for review August 7, 2024 18:02
@mpgxvii mpgxvii changed the base branch from dev to hydra-kratos-stack August 13, 2024 18:24
Bdegraaf1234
Bdegraaf1234 reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@Bdegraaf1234 Bdegraaf1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, If you tested I won't hold this back but there are some chores we should keep tabs on

src/main/java/org/radarbase/management/service/UserService.kt Show resolved Hide resolved
src/main/java/org/radarbase/management/service/UserService.kt Show resolved Hide resolved
src/main/java/org/radarbase/management/service/UserService.kt Show resolved Hide resolved
@mpgxvii mpgxvii changed the base branch from hydra-kratos-stack to feature/ory-based-authorization August 15, 2024 11:26
@Bdegraaf1234 Bdegraaf1234 marked this pull request as draft August 19, 2024 14:43
@mpgxvii mpgxvii changed the base branch from feature/ory-based-authorization to feat/hydra-token August 27, 2024 15:12
@mpgxvii
Copy link
Member Author

mpgxvii commented Aug 28, 2024

Closing, moved here: #945

@mpgxvii mpgxvii closed this Aug 28, 2024
@mpgxvii mpgxvii deleted the add-kratos-endpoint branch August 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan left review comments

@Bdegraaf1234 Bdegraaf1234 Bdegraaf1234 left review comments

@nivemaham nivemaham Awaiting requested review from nivemaham

@peyman-mohtashami peyman-mohtashami Awaiting requested review from peyman-mohtashami

@pvannierop pvannierop Awaiting requested review from pvannierop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpgxvii @Bdegraaf1234 @yatharthranjan