Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply scopecheck where applicable #749

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Apply scopecheck where applicable #749

merged 1 commit into from
Feb 23, 2024

Conversation

Bdegraaf1234
Copy link
Member

@Bdegraaf1234 Bdegraaf1234 commented Feb 15, 2024 •
edited
Loading

Fix issues with the projectAdmin not being able to access resources they should be able to acces.

Description: Replace permission checks with scope checks for resources that should not be subject to entity-based filtering

Fixes #746

Checklist:

  • The Main workflow has succeeded
  • The Gatling tests have passed
  • I have logged into the portal running locally with default admin credentials
  • I have updated the README files if this change requires documentation update
  • I have commented my code, particularly in hard-to-understand areas

@Bdegraaf1234 Bdegraaf1234 marked this pull request as draft February 23, 2024 11:21
@Bdegraaf1234 Bdegraaf1234 marked this pull request as ready for review February 23, 2024 11:57
peyman-mohtashami
peyman-mohtashami approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@peyman-mohtashami peyman-mohtashami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bdegraaf1234 Bdegraaf1234 merged commit 691d410 into dev Feb 23, 2024
7 of 8 checks passed
@Bdegraaf1234 Bdegraaf1234 deleted the bugfix-project-manager-permissions branch February 23, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peyman-mohtashami peyman-mohtashami peyman-mohtashami approved these changes

@nivemaham nivemaham Awaiting requested review from nivemaham nivemaham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bdegraaf1234 @peyman-mohtashami