724 redirect traffic from to managementportal #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gementportal should be redirected to the root. This is because these requests are formatted as they would be when pointed to production servers where requests to managementportal are prefixed with /managementportal
…his is the default port where we expose managementportal in production/docker so this makes web-requests universal between the dev environment and (locally hosted) production builds
|
@Bdegraaf1234 Is this still WIP? Otherwise it can be merged in. |
|
No it's ready for review imo :) |
This was referenced Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Change some dev-settings to simplify development by making web-requests sent to the Angular Live Development Server (ALDS) follow the same routes as web-requests sent to (locally hosted) prod builds (i.e. the docker images used in this and other repos)
One "breaking" change is that the ALDS is now hosted at port 8081, as this is the default port we host management portal on when hosted in conjunction with other services.
furthermore, requests pointing to {ALDS}/managementportal are redirected to root, and a description of the client credential authorization workflow was added to the readme
Fixes #724
Checklist: