Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update radar auth logic #705

Merged
merged 24 commits into from
May 10, 2023
Merged

Update radar auth logic #705

merged 24 commits into from
May 10, 2023

Conversation

blootsvoets
Copy link
Member

Changes:

  • Use ktor as HTTP client instead of OkHttp
  • Use Kotlin coroutines to do authentication handling in an efficient way
  • Incorporate all permission handling in radar-auth, including the choice on what functionality to test.
  • Make an extendable AuthorizationOracle, instead of a static RadarAuthorization class.
  • Provide an interface to AuthorizationOracle to determine the links between a project and an organization. This allows services to use their own method for determining the relationships between entities.

@blootsvoets
Use ktor instead of okhttp
4efd120
@blootsvoets
Update to the latest Kotlin version
6be785f
@blootsvoets
Small fix
4f22bbe
@blootsvoets
Update Gradle and fix MP client client credentials
dcb7b1a
@blootsvoets
Check authorization via an AuthorizationOracle
221c053 
Refactorings include:
- Convert radar-auth to Kotlin
- Allow tokens other than JWTs to be verified
- Move all permission checks out of RadarToken
- Allow the AuthorizationOracle to check organization <-> project links
- Remove configuration parsing from radar-auth
- Use ktor client to fetch public keys
- Use coroutines to verify keys
@blootsvoets
Merge remote-tracking branch 'origin/dev' into update-radar-auth-logic
bebef33
@blootsvoets
Tested logic with radar-jersey
0347668
@blootsvoets
Add separate kotlin-util library
6e22229
@blootsvoets
Added suspended get for futures
54ad101
@blootsvoets
Added group to client MPSubject
f1bf418
@blootsvoets
Ensure that projects return their enclosing organization
aee7364
@blootsvoets
CachedValue documentation and simplification
1951938
@blootsvoets
Do not consider empty cache stale
d69ad3c
@blootsvoets
Renamed kotlin-util -> radar-kotlin
d42d051
@blootsvoets
Merge branch 'dev' into update-radar-auth-logic
35fef55
@blootsvoets
Moved radar-kotlin to radar-commons/radar-commons-kotlin
3df0a06
@blootsvoets
Removed deprecated oauth-client-util
be07590
@blootsvoets
[GA] Bump snyk version
c670029
@blootsvoets
Cleanup build logic
5299ad3
@blootsvoets
Bump versions
fe8fa1b
@blootsvoets
Add token copy method
eaa8a89
@blootsvoets
Bump gradle wrapper and dependencies
c2beaa6 
Update dependencies
@blootsvoets
Fix Snyk issues
b51ed8d
@blootsvoets
Fix Spring loading issues
9b0e667
@blootsvoets blootsvoets marked this pull request as ready for review May 10, 2023 09:20
@blootsvoets blootsvoets merged commit 46e96c3 into dev May 10, 2023
@blootsvoets blootsvoets deleted the update-radar-auth-logic branch May 10, 2023 11:42
@blootsvoets blootsvoets mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivemaham nivemaham Awaiting requested review from nivemaham nivemaham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@blootsvoets