Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a bug about crashes down when there are two slashes. #6855

Merged
merged 9 commits into from
Sep 16, 2024
Merged

fix: a bug about crashes down when there are two slashes. #6855

merged 9 commits into from
Sep 16, 2024

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Sep 3, 2024 •
edited
Loading

What is it?

#6004

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner September 3, 2024 01:20
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 6a77982

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JerryWu1234
Copy link
Contributor Author

image

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 3, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6855

npm i https://pkg.pr.new/@builder.io/qwik-city@6855

npm i https://pkg.pr.new/eslint-plugin-qwik@6855

npm i https://pkg.pr.new/create-qwik@6855

commit: 6a77982

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 6a77982

@JerryWu1234
Copy link
Contributor Author

JerryWu1234 commented Sep 6, 2024 •
edited
Loading

image
here as result

@wmertens

@JerryWu1234
Copy link
Contributor Author

image
However I tested in my local

wmertens
wmertens requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there 😊

.changeset/forty-humans-jump.md Outdated Show resolved Hide resolved
packages/qwik/src/optimizer/src/plugins/image-size-server.ts Outdated Show resolved Hide resolved
@JerryWu1234
Copy link
Contributor Author

@wmertens everything is fine

wmertens
wmertens approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 0d57dc8 into QwikDev:main Sep 16, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JerryWu1234 @wmertens