Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a bug 4956 #6778

Merged
merged 16 commits into from
Sep 11, 2024
Merged

fix: a bug 4956 #6778

merged 16 commits into from
Sep 11, 2024

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Aug 8, 2024

Overview

#4956
#6753

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: feec328

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Aug 8, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6778
npm i https://pkg.pr.new/@builder.io/qwik-city@6778
npm i https://pkg.pr.new/eslint-plugin-qwik@6778
npm i https://pkg.pr.new/create-qwik@6778

commit: feec328

Copy link
Contributor

github-actions bot commented Aug 8, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview feec328

@JerryWu1234 JerryWu1234 marked this pull request as ready for review August 12, 2024 01:25
@JerryWu1234 JerryWu1234 requested a review from a team as a code owner August 12, 2024 01:25
@JerryWu1234
Copy link
Contributor Author

have already had tests

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit ee24c89 into QwikDev:main Sep 11, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants