Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preserve modules to lib starter #6773

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

thejackshelton
Copy link
Member

Overview

Adds preserve modules to the library starters. It also makes the entryname apparent in the build, otherwise you would have:
index.qwik2.mjs and so forth.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@thejackshelton thejackshelton requested a review from a team as a code owner August 7, 2024 03:11
Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: 1821692

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
create-qwik Patch
@builder.io/qwik Patch
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thejackshelton thejackshelton changed the title add preserve modules to lib starter feat: add preserve modules to lib starter Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ❌ Failed (View Log) 1821692

gioboa
gioboa previously approved these changes Aug 7, 2024
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thejackshelton yessss 👍

@wmertens
Copy link
Member

wmertens commented Aug 7, 2024

Needs a changeset with why

Copy link
Contributor

@shairez shairez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Wout said, this needs a changeset

@thejackshelton
Copy link
Member Author

Good catch will add one here soon

@shairez shairez merged commit 6f498cb into QwikDev:main Aug 13, 2024
15 checks passed
@github-actions github-actions bot mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants