fix(starters): Fix vite types referencing in base starter

[octet-stream]

Closes #6059

Overview

What is it?

• Feature / enhancement
• Bug
• Docs / tests / types / typos

Description

It's been about a month since this PR was opened and to this point I doubt that it is going somewhere, so I decided to take over and fix this issue, using the same solution I have proposed here, and I was able to verify it is working.

Use cases and why

My previous attempt to fix types for Bun turned out to be incomplete, so this PR fixes the issue. Here's a brief list of changes:

• Move vite/client types referencing to a separate file called qwik.env.d.ts. This file can be used for more global typings in a future, if needed.
• Remove types field in compilerOptions for base app starter with a reference to that file in includes field instead.

As I said before, the types field narrows the list of the sources where TypeScript will look for typings for global scope, so I don't think it would be a good fit when there's many other typings that can be needed from node_modules/@types. In our case, we need to support both @types/node and @types/bun both of which has global types. See documentation for more info: https://www.typescriptlang.org/tsconfig#types

Checklist:

• My code follows the developer guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• Added new tests to cover the fix / functionality

[wmertens]

I like the idea of not pinning types, but can you add a comment to that effect in your new qwik.env file?

comment was added