Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(deprecated-features): routeAction$ #6140

Merged
merged 1 commit into from
Apr 22, 2024
Merged

docs(deprecated-features): routeAction$ #6140

merged 1 commit into from
Apr 22, 2024

Conversation

PatrickJS
Copy link
Member

@PatrickJS PatrickJS commented Apr 21, 2024 •
edited
Loading

routeAction$

gioboa
gioboa approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @PatrickJS

@gioboa gioboa merged commit 0b4b6c5 into main Apr 22, 2024
24 checks passed
@gioboa gioboa deleted the docs-deprecated-features-route-action branch April 22, 2024 07:31
@wmertens
Copy link
Member

@gioboa it doesn't support base yet, I don't think this was ready to merge :(

Anyway @PatrickJS you can use import.meta.env.BASE_URL I think.

@wmertens
Copy link
Member

oops I meant #6141 - sorry for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatrickJS @wmertens @gioboa