Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update vite.config.ts to externalize async_hooks #5908

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Feb 29, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@mhevery mhevery enabled auto-merge (squash) February 29, 2024 05:45
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for qwik-insights failed.

Name Link
🔨 Latest commit 05b91ef
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/65e019f836c6280008bf9cdf

@mhevery mhevery merged commit 5b1e773 into main Feb 29, 2024
21 of 27 checks passed
@mhevery mhevery deleted the mhevery-patch-2 branch February 29, 2024 05:48
@brandonpittman
Copy link
Contributor

brandonpittman commented Mar 5, 2024

@mhevery After upgrading to 1.5.0, I'm getting errors that mention async_hooks. Could it be related to this?

Nothing pops up in development, but errors occur when building for production. Locking Qwik @ 1.4.5 works fine.

error during build:
RollupError: Cannot bundle Node.js built-in "node:async_hooks" imported from "../../node_modules/@builder.io/qwik-city/middleware/request-handler/index.mjs". Consider disabling ssr.noExternal or remove the built-in dependency.
    at error (file:///XXX/node_modules/rollup/dist/es/shared/node-entry.js:2287:30)
    at Object.error (file:///XXX/node_modules/rollup/dist/es/shared/node-entry.js:25351:20)
    at Object.resolveId (file:///XXX/node_modules/vite/dist/node/chunks/dep-52909643.js:28225:34)
    at Object.handler (file:///XXX/node_modules/vite/dist/node/chunks/dep-52909643.js:48308:19)
    at file:///XXX/node_modules/rollup/dist/es/shared/node-entry.js:25544:40
    at async PluginDriver.hookFirstAndGetPlugin (file:///XXX/node_modules/rollup/dist/es/shared/node-entry.js:25444:28)
    at async resolveId (file:///XXX/node_modules/rollup/dist/es/shared/node-entry.js:24117:26)
    at async ModuleLoader.resolveId (file:///XXX/node_modules/rollup/dist/es/shared/node-entry.js:24531:15)
    at async Object.resolveId (file:///XXX/node_modules/vite/dist/node/chunks/dep-52909643.js:7910:10)
    at async PluginDriver.hookFirstAndGetPlugin (file:///XXX/node_modules/rollup/dist/es/shared/node-entry.js:25444:28)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants