fix: server request event retention during async handling #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
wmertens
changed the title
PatrickJS
reviewed
Feb 28, 2024
mhevery
reviewed
Feb 29, 2024
starters/apps/qwikcity-test/src/routes/(common)/server-func/index.tsx
Outdated
Show resolved
Hide resolved
|
I'm updating the tests |
7 tasks
mhevery
approved these changes
Feb 29, 2024
Co-authored-by: Miško Hevery <misko@hevery.com>
Co-authored-by: Miško Hevery <misko@hevery.com>
Co-authored-by: Miško Hevery <misko@hevery.com>
mhevery
reviewed
Feb 29, 2024
| @@ -27,6 +27,12 @@ import type { QwikManifest, ResolvedManifest } from '@builder.io/qwik/optimizer' | |||
| import { IsQData, QDATA_JSON, QDATA_JSON_LEN } from './user-response'; | |||
| import { isPromise } from './../../runtime/src/utils'; | |||
|
|
|||
| // TODO: create single QGlobal type | |||
| type AsyncStore = import('node:async_hooks').AsyncLocalStorage<RequestEventInternal>; | |||
There was a problem hiding this comment.
Why are you doing a dynamic import here? Why not just regular static import? See https://developers.cloudflare.com/workers/runtime-apis/nodejs/asynclocalstorage/
There was a problem hiding this comment.
Because if it's running somewhere without ALS, it can behave as before. Presumably this type import doesn't crash then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4417
This passes one test already, but it needs to use a global to communicate between the qwik-city middleware and the qwik-city server functions, so it's not ideal.