Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add missing server$ import in Getting started example #5895

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

mittinatten
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Adds a missing import in part 5 of the Getting started tutorial.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Feb 27, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 00bee3d

@mittinatten mittinatten changed the title Add missing server$ import in Getting started example docs: Add missing server$ import in Getting started example Feb 27, 2024
@gioboa
Copy link
Member

gioboa commented Feb 27, 2024

Hi @mittinatten thanks for your contribution. Did you try the documentation locally with docs.dev script?

@gioboa gioboa added the COMP: docs Improvements or additions to documentation label Feb 27, 2024
@mittinatten
Copy link
Contributor Author

Hi @mittinatten thanks for your contribution. Did you try the documentation locally with docs.dev script?

I did now and found a typo, that is fixed. (Originally did this solely by clicking the edit button in the docs).

Building the docs changed a bunch of other files too, should those changes be included in the PR too?

@gioboa
Copy link
Member

gioboa commented Feb 27, 2024

Are they related to your change? Can you list them pls?

@mittinatten
Copy link
Contributor Author

Are they related to your change? Can you list them pls?

I think I got some unwanted upstream changes rebasing my branch. I checked out the originals of all the changed files and rebuilt the docs, and now it looks fine again. Sorry for the confusion.

Here's the output from git before I did the checkout:
Screenshot 2024-02-27 at 08 00 42

@gioboa
Copy link
Member

gioboa commented Feb 27, 2024

Yeah, It Is strange but don't worry.
Thanks ☺️ we really appreciate your help.

@gioboa gioboa merged commit dd235d1 into QwikDev:main Feb 27, 2024
22 checks passed
@mittinatten mittinatten deleted the patch-2 branch February 27, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants