Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tailwind starter): switch from cjs to esm to support vite 5 #5635

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

thejackshelton
Copy link
Member

@thejackshelton thejackshelton commented Dec 24, 2023

When adding the tailwind integration with 1.3.1, we get the following error:

node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[Failed to load PostCSS config: Failed to load PostCSS config (searchPath: /Volumes/Primary/Code/eatess/cruncho-landing): [ReferenceError] module is not defined in ES module scope
This file is being treated as an ES module because it has a '.js' file extension and '/Volumes/Primary/Code/eatess/cruncho-landing/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
ReferenceError: module is not defined in ES module scope
This file is being treated as an ES module because it has a '.js' file extension and '/Volumes/Primary/Code/eatess/cruncho-landing/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.

This is vite 5 telling us we are using CJS, and we should either have it as an es module, or rename the file to .cjs so that CJS continues to work.

https://vitejs.dev/guide/migration.html#deprecate-cjs-node-api

It seems that ESM works fine here, so I've made a tiny PR so that this behavior is fixed.

Related:
https://discord.com/channels/842438759945601056/1188215300236251279/1188268842682699846
https://discord.com/channels/842438759945601056/1187876025913327756/1187876025913327756

Copy link

netlify bot commented Dec 24, 2023

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d033a1b

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thejackshelton you rock

@gioboa gioboa merged commit 072d0b3 into QwikDev:main Dec 24, 2023
23 checks passed
@gioboa gioboa mentioned this pull request Dec 24, 2023
7 tasks
kodiakhq bot pushed a commit to ascorbic/unpic-img that referenced this pull request Jan 7, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@builder.io/qwik](https://qwik.builder.io/) ([source](https://github.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.3.1` -> `1.3.2`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.3.1/1.3.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.3.1/1.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.3.1/1.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>BuilderIO/qwik (@&#8203;builder.io/qwik)</summary>

### [`v1.3.2`](https://github.com/BuilderIO/qwik/releases/tag/v1.3.2)

[Compare Source](https://github.com/BuilderIO/qwik/compare/v1.3.1...v1.3.2)

##### What's Changed

-   docs: update portal cookbook with solved problems by [@&#8203;thejackshelton](https://github.com/thejackshelton) in [QwikDev/qwik#5600
-   chore: Add notice about service worker usage by [@&#8203;nelsonprsousa](https://github.com/nelsonprsousa) in [QwikDev/qwik#5606
-   fix: Bun integration env.get is undefined by [@&#8203;phyrog](https://github.com/phyrog) in [QwikDev/qwik#5601
-   fix(insights): form errors by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5607
-   fix(qwik-insights): fix up create application form by [@&#8203;iamriajul](https://github.com/iamriajul) in [QwikDev/qwik#5573
-   docs(layout): Add "Slot" import by [@&#8203;HenriqueLimas](https://github.com/HenriqueLimas) in [QwikDev/qwik#5612
-   fix(tests): fix typos by [@&#8203;maiieul](https://github.com/maiieul) in [QwikDev/qwik#5616
-   fix: Correct qwik types by [@&#8203;mhevery](https://github.com/mhevery) in [QwikDev/qwik#5623
-   fix(docs): add missing cookbook section by [@&#8203;gioboa](https://github.com/gioboa) in [QwikDev/qwik#5626
-   fix(tailwind starter): switch from cjs to esm to support vite 5 by [@&#8203;thejackshelton](https://github.com/thejackshelton) in [QwikDev/qwik#5635
-   docs: fix up markdown rendering by [@&#8203;ValentinBossi](https://github.com/ValentinBossi) in [QwikDev/qwik#5532
-   refactor(insights): improve consistency  by [@&#8203;iamriajul](https://github.com/iamriajul) in [QwikDev/qwik#5609
-   docs: improve getting started steps by [@&#8203;shwosner](https://github.com/shwosner) in [QwikDev/qwik#5620
-   docs: improve eslint loader msg + add cookbook example by [@&#8203;gioboa](https://github.com/gioboa) in [QwikDev/qwik#5591
-   fix(ssr): slot subscribers by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5608
-   docs: create NavLink cookbook example by [@&#8203;Adbib](https://github.com/Adbib) in [QwikDev/qwik#5621
-   fix(tailwind): fix prettier config type by [@&#8203;shairez](https://github.com/shairez) in [QwikDev/qwik#5641
-   docs: add Node Docker deploy example by [@&#8203;nelsonprsousa](https://github.com/nelsonprsousa) in [QwikDev/qwik#5605
-   docs(cookbook): font optimization guide by [@&#8203;thejackshelton](https://github.com/thejackshelton) in [QwikDev/qwik#5645
-   fix: rendering ssr and csr for value="" by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5642
-   fix: remove unnecessary whitespace when handling classes by [@&#8203;jakovljevic-mladen](https://github.com/jakovljevic-mladen) in [QwikDev/qwik#5648
-   fix(jsx): dynamic DOM element props by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5650
-   refactor(jsx): tiny improvement by [@&#8203;wmertens](https://github.com/wmertens) in [QwikDev/qwik#5654
-   feat: add `skipConfirmation` to cli add command by [@&#8203;shairez](https://github.com/shairez) in [QwikDev/qwik#5655
-   chore: 1.3.2 by [@&#8203;shairez](https://github.com/shairez) in [QwikDev/qwik#5661

##### New Contributors

-   [@&#8203;phyrog](https://github.com/phyrog) made their first contribution in [QwikDev/qwik#5601
-   [@&#8203;HenriqueLimas](https://github.com/HenriqueLimas) made their first contribution in [QwikDev/qwik#5612
-   [@&#8203;ValentinBossi](https://github.com/ValentinBossi) made their first contribution in [QwikDev/qwik#5532
-   [@&#8203;shwosner](https://github.com/shwosner) made their first contribution in [QwikDev/qwik#5620

**Full Changelog**: QwikDev/qwik@v1.3.1...v1.3.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants