fix(qrl.ts): dedupe sync$ #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
mhevery
pushed a commit
that referenced
this pull request
Dec 15, 2023
* fix(qrl.ts): dedupe sync$ * refactor(core): sync$ inlineFns key
mhevery
added a commit
that referenced
this pull request
Dec 15, 2023
* feat(qwik): Experimental support for synchronous QRL `sync$()`.
It is often desirable to have call API on events synchronously. For example, `event.preventDefault()` and `event.stopPropagation()` must be called synchronously in order to have a helpful effect.
```TypeScript
<button onClick$={[
$sync(event => event.preventDefault()),
$(() => {
// normal behavior.
})
]}>Click Me</button>
```
The idea is that `$sync()` will be inlined into HTML. For this reason, the function, `$sync()`, must not only be a pure function but also can not depend on any external code, such as imports.
The best way to think about it is that the function inside `$sync()` must be able to survive `fn.toString()` and then be reconstructed from the string into a proper function.
In practice, this means that the function must be a simple function which can't:
- Close over any state.
- Close over any imports.
Fix #5322
Fix #4496
* fix(qrl.ts): dedupe sync$ (#5566)
* fix(qrl.ts): dedupe sync$
* refactor(core): sync$ inlineFns key
* feat(qwik): Experimental support for synchronous QRL `sync$()`.
It is often desirable to have call API on events synchronously. For example, `event.preventDefault()` and `event.stopPropagation()` must be called synchronously in order to have a helpful effect.
```TypeScript
<button onClick$={[
$sync(event => event.preventDefault()),
$(() => {
// normal behavior.
})
]}>Click Me</button>
```
The idea is that `$sync()` will be inlined into HTML. For this reason, the function, `$sync()`, must not only be a pure function but also can not depend on any external code, such as imports.
The best way to think about it is that the function inside `$sync()` must be able to survive `fn.toString()` and then be reconstructed from the string into a proper function.
In practice, this means that the function must be a simple function which can't:
- Close over any state.
- Close over any imports.
Fix #5322
Fix #4496
---------
Co-authored-by: PatrickJS <github@patrickjs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dedupe sync$ functions
What is it?
Description
ensure sync$ functions are only included once
Use cases and why
Checklist: