feat: When closing over values in server$ the values should be marked as readonly
#5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…should be marked as readonly Co-authored-by: wajihaNiazi <waijehaniazi204@gmail.com> Co-authored-by: Phu Nguyen <51897872+phunguyenmurcul@users.noreply.github.com>
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
gioboa
added
COMP: qwik-city
STATUS-2: PR waiting for review
|
Love this change. Let me know when it is ready. |
wmertens
previously requested changes
Oct 5, 2023
There was a problem hiding this comment.
Can you also add an e2e spec that tries to change an object on the server? Something like
server$(() => {
try {
myObject.deeper.foo = 'test'
return false
} catch (e) {
if (/* some test that checks it errored because of freeze */)
return true
return false
}
})
|
Hi @gitstart thanks for your help, are you still on this PR or is it abandoned? |
Sorry for the delay. we are still working on the issue |
…should be marked as readonly Co-authored-by: Hameed Abdulrahaman <hameedabdulrahamann@gmail.com> Co-authored-by: wajihaNiazi <waijehaniazi204@gmail.com> Co-authored-by: Phu Nguyen <51897872+phunguyenmurcul@users.noreply.github.com>
|
@gitstart could you rebase? |
wmertens
reviewed
Nov 22, 2023
|
@gitstart still interested in finishing this? |
PatrickJS
changed the title
server$ the values should be marked as readonlyserver$ the values should be marked as readonly
|
in the future technically we can pass the current client value to the server then update the client signals from the server response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR ensures that values serialized by server$() are immutable and triggers a clear error message if any mutation is attempted
Issue reference
#5019
Demo video/scrennshot:
https://www.loom.com/share/abc8b587001d4845bc55748000b0412f?sid=945d461e-79cc-4cd3-a80f-0e99bb0aa065
Happy hacking! 🎉
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.