fix(create-app): xdev renames + node versions

QwikDev · Mar 4, 2024 · 11aed89 · 11aed89
1 parent 404e0e6
commit 11aed89
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 6 deletions.
diff --git a/packages/create-qwik/package.json b/packages/create-qwik/package.json
@@ -12,9 +12,12 @@
     "yargs": "17.7.2"
   },
   "engines": {
-    "node": ">=16.8.0 <18.0.0 || >=18.11",
-    "npm": ">=6.0.0"
+    "node": "^18.17.0 || ^20.3.0 || >=21.0.0",
+    "npm": ">=10.0.0",
+    "pnpm": ">=8.0.0",
+    "yarn": ">=3.0.0"
   },
+  "engines-annotation": "Mostly required by sharp which needs a Node-API v9 compatible runtime",
   "files": [
     "create-qwik.cjs",
     "index.cjs",

diff --git a/packages/qwik/src/cli/utils/install-deps.ts b/packages/qwik/src/cli/utils/install-deps.ts
@@ -1,6 +1,5 @@
 import { bgRed, cyan, red } from 'kleur/colors';
 import fs from 'node:fs';
-import os from 'node:os';
 import path from 'node:path';
 import { log } from '@clack/prompts';
 import type { IntegrationData } from '../types';
@@ -15,11 +14,19 @@ export function runInPkg(pkgManager: string, args: string[], cwd: string) {
   return runCommand(cmd, args, cwd);
 }
 
+/**
+ * This does an initial install of the base dependencies in the background while the install is
+ * running. Afterwards the actual dependencies get added and the package manager re-run
+ */
 export function backgroundInstallDeps(pkgManager: string, baseApp: IntegrationData) {
   const { tmpInstallDir } = setupTmpInstall(baseApp);
 
   const { install, abort } = installDeps(pkgManager, tmpInstallDir);
 
+  install.finally(() => {
+    fs.rmdirSync(tmpInstallDir, { recursive: true });
+  });
+
   const complete = async (outDir: string) => {
     let success = false;
 
@@ -84,11 +91,12 @@ export function backgroundInstallDeps(pkgManager: string, baseApp: IntegrationDa
 
 function setupTmpInstall(baseApp: IntegrationData) {
   const tmpId =
-    'create-qwik-' +
+    '.create-qwik-' +
     Math.round(Math.random() * Number.MAX_SAFE_INTEGER)
       .toString(36)
       .toLowerCase();
-  const tmpInstallDir = path.join(os.tmpdir(), tmpId);
+  // Keep in same mountpoint so renames can move quickly
+  const tmpInstallDir = path.join(baseApp.dir, tmpId);
 
   try {
     fs.mkdirSync(tmpInstallDir);

diff --git a/starters/apps/base/package.json b/starters/apps/base/package.json
@@ -33,9 +33,14 @@
   "trustedDependencies": [
     "sharp"
   ],
+  "trustedDependencies-annotation": "Needed for bun to allow running install scripts",
   "engines": {
-    "node": ">=16.8.0 <18.0.0 || >=18.11"
+    "node": "^18.17.0 || ^20.3.0 || >=21.0.0",
+    "npm": ">=10.0.0",
+    "pnpm": ">=8.0.0",
+    "yarn": ">=3.0.0"
   },
+  "engines-annotation": "Mostly required by sharp which needs a Node-API v9 compatible runtime",
   "private": true,
   "type": "module"
 }