fix: Suppress binder warning for rogue properties

Quenty · Jul 1, 2023 · 06cafc6 · 06cafc6
1 parent b937c37
commit 06cafc6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/rogue-properties/src/Shared/Modifiers/Additive/RogueAdditiveProvider.lua b/src/rogue-properties/src/Shared/Modifiers/Additive/RogueAdditiveProvider.lua
@@ -4,6 +4,8 @@
 
 local require = require(script.Parent.loader).load(script)
 
+local RunService = game:GetService("RunService")
+
 local Rx = require("Rx")
 local RxBinderUtils = require("RxBinderUtils")
 local RxBrioUtils = require("RxBrioUtils")
@@ -42,7 +44,11 @@ function RogueAdditiveProvider:Create(additive, source)
 		RoguePropertyModifierUtils.createSourceLink(obj, source)
 	end
 
-	self._rogueBinders.RogueAdditive:Bind(obj)
+	if RunService:IsClient() then
+		self._rogueBinders.RogueAdditive:BindClient(obj)
+	else
+		self._rogueBinders.RogueAdditive:Bind(obj)
+	end
 
 	return obj
 end

diff --git a/src/rogue-properties/src/Shared/Modifiers/Multiplier/RogueMultiplierProvider.lua b/src/rogue-properties/src/Shared/Modifiers/Multiplier/RogueMultiplierProvider.lua
@@ -4,6 +4,8 @@
 
 local require = require(script.Parent.loader).load(script)
 
+local RunService = game:GetService("RunService")
+
 local Rx = require("Rx")
 local RxBinderUtils = require("RxBinderUtils")
 local RxBrioUtils = require("RxBrioUtils")
@@ -42,7 +44,11 @@ function RogueMultiplierProvider:Create(multiplier, source)
 		RoguePropertyModifierUtils.createSourceLink(obj, source)
 	end
 
-	self._rogueBinders.RogueMultiplier:Bind(obj)
+	if RunService:IsClient() then
+		self._rogueBinders.RogueMultiplier:BindClient(obj)
+	else
+		self._rogueBinders.RogueMultiplier:Bind(obj)
+	end
 
 	return obj
 end