Add pulse instruction and schedule equality testing #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taalexander
requested review from
1ucian0,
ajavadia,
atilag,
chriseclectic,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
mtreinish and
nonhermitian
as code owners
… the super class of eq.
lcapelluto
suggested changes
Jul 29, 2019
Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com>
Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com>
… into schedule-equality-check
This test happening in checking that the underlying tuple is equal. It has a form of |
|
This should be good to go now. |
lcapelluto
previously approved these changes
Aug 13, 2019
lcapelluto
previously approved these changes
Aug 13, 2019
lcapelluto
approved these changes
Aug 14, 2019
|
Azure returned successfully on all jobs: https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=1822 it's just the recent issue where the azure<->github communication fails and nothing gets updated. Since the jobs all succeeded I'm going to go ahead and merge this |
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
This adds pulse instruction and schedule equality testing. This will make writing Schedule tests easier. I also added a small change to return instructions with a fixed ordering. This was required for the initial way I implemented equality testing, but have since refactored so that it is not necessary. Instruction testing verifies that the lhs and rhs have the same Command on the same channels. Schedule testing first ensures that the lhs and rhs each have the same channels and the same number of instructions. Then it verifies that each instruction at each time in the rhs is contained within the rhs. * Add schedule and instruction equality testing. * Modify equality check to be more straight forward. * Updated changelog. * refactor equality checking of Commands to not check name and also use the super class of eq. * Update qiskit/pulse/commands/command.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * Fix unpythonic equality checks. * Add proper hashes for commands. * Update test/python/pulse/test_schedule.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * Change equality check to be based on position in .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds pulse instruction and schedule equality testing. This will make writing Schedule tests easier.
I also added a small change to return
instructionswith a fixed ordering. This was required for the initial way I implemented equality testing, but have since refactored so that it is not necessary. This feature may still be desired so I have left it in, please let me know if I should remove.Details and comments
Instruction testing verifies that the lhs and rhs have the same Command on the same channels.
Schedule testing first ensures that the lhs and rhs each have the same channels and the same number of instructions. Then it verifies that each instruction at each time in the rhs is contained within the rhs.