Fixed multi parameter bug #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samanthavbarron
commented
Jul 5, 2019
| cmd_def = CmdDef() | ||
| cmd_def.add('test', 0, par_sched) | ||
|
|
||
| actual = cmd_def.get('test', 0, 0.01, 0.02, 0.03) |
There was a problem hiding this comment.
Closes #2741
samanthavbarron
commented
Jul 5, 2019
| self.assertEqual(actual.start_time, expected.start_time) | ||
| self.assertEqual(actual.stop_time, expected.stop_time) | ||
|
|
||
| self.assertEqual(cmd_def.get_parameters('test', 0), ('x', 'y', 'z')) |
There was a problem hiding this comment.
Closes #2742
added 2 commits
July 5, 2019 19:25
samanthavbarron
requested review from
1ucian0,
ajavadia,
atilag,
chriseclectic,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
lcapelluto,
mtreinish,
nonhermitian and
taalexander
as code owners
taalexander
approved these changes
Jul 8, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Remove repeated parameters * Updated changelog * Update CHANGELOG.md * Adding test * Adding test of CmdDef arguments issue being fixed * Formatting * Formatting * Formatting * Formatting * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2742, and
possiblycloses #2741.Details and comments
I don't have a concise tests of this to add yet, so this is just a draft for now until I can find some.