Extend commutative cancellation for SX/Sdg/Tdg #13058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
the
Changelog: Bugfix
|
One or more of the following people are relevant to this code:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
CommmutativeCancellationpass didn't consider cancellations ofSdg/Tdg/SX/SXdggates. This PR does a minor fix to add them.Details and comments
There are other open points we might want to discuss:
Z-Zis not cancelled if there is noRZ/U1/Pspecified in the basis set or targetBoth these cases could be solved by e.g. always assuming an RX/RZ rotation gate to absorb the cancellations, but if finally the angles don't sum up to 0, we disregard the accumulation.