-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update random_circuit fuction in qiskit.circuit.random.utils.py #13054
base: main
Are you sure you want to change the base?
Conversation
Adding random_clifford_T_circuit to support random circuits selects T and Tdg as elements.
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
Thanks for opening a PR @PhysicsQoo! But I think we could tackle your issue in a bit a more general fashion, I just left a comment on your issue. |
Description: Added a gates: list[str] | None argument, replacing the hardcoded gate list with standard_gates.get_standard_gate_name_mapping(). Introduced a parameterized argument, allowing users to select whether they want parameterized rotation gates. Known Issue: The parameterized functionality currently encounters an AttributeError: 'Parameter' object has no attribute '_root_uuid'. This issue is yet to be resolved. The feature works correctly when parameterized = False.
Description:Added a Known Issue:The parameterized functionality currently encounters an AttributeError: 'Parameter' object has no attribute '_root_uuid'. This issue is yet to be resolved. |
Dear @PhysicsQoo, it's nice to see that you're motivated to implement the additions to the random circuit -- but we have to approach this a bit differently: for this PR, we cannot remove existing functionality. We can do the following steps:
Importantly, we don't change any of the existing functionality that creates the circuit with a certain depth or handles the operand distribution or parameterization. In a next step, we can have a look at supporting also |
Summary
Adding random_clifford_T_circuit to support random circuits selects T and Tdg as elements.
Details and comments
part of #13053