Remove patching of SwapGate.__new__ from Sabre test
#11012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This made sense as a way of tracking the progress of Sabre back when our implementation was pure-Python and generated the swaps on-the-fly, but ever since it moved to Rust, the infinite loop would have happened before any swaps were constructed at all. With the move to singleton gates, this test can cause problems; the restoration after the patching can cause issues with the singleton-return apparatus.
jakelishman
added
type: qa
|
One or more of the the following people are requested to review this:
|
mtreinish
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This made sense as a way of tracking the progress of Sabre back when our implementation was pure-Python and generated the swaps on-the-fly, but ever since it moved to Rust, the infinite loop would have happened before any swaps were constructed at all.
With the move to singleton gates, this test can cause problems; the restoration after the patching can cause issues with the singleton-return apparatus.
Details and comments