Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Fixed some typos in "05_Sampling_potential_energy_surface" #1125

Merged
merged 10 commits into from
Mar 5, 2021
Merged

Fixed some typos in "05_Sampling_potential_energy_surface" #1125

merged 10 commits into from
Mar 5, 2021

Conversation

divshacker
Copy link
Contributor

Summary

This PR is clearly the fix of #1124 . There were some typos in 05_Sampling_potential_energy_surface
in Extrapolation Section.

Details and comments

I have tried to fix the problem please have a look and let me know if any changes required .
Thank you

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@divshacker
Copy link
Contributor Author

@SooluThomas @nonhermitian @Feigenbaum4669 Please have a look and let me know

@divshacker
Copy link
Contributor Author

I don't know why all test got failed. Give me some time .
I will push it again.

@divshacker
Copy link
Contributor Author

@SooluThomas @nonhermitian Please check now I think the problem is fixed now .
Thank You

@divshacker
Copy link
Contributor Author

@SooluThomas are you guys doing that ?

@divshacker
Copy link
Contributor Author

@SooluThomas please review this pr also and let me know any changes required. It's been two weeks now .😅🙂

Copy link
Member

@SooluThomas SooluThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some minor suggestions here

@@ -1,534 +1,609 @@
{
Copy link
Member

@SooluThomas SooluThomas Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please re-run this cell with the most recent versions?

I mean the very las cell

import qiskit.tools.jupyter
%qiskit_version_table
%qiskit_copyright

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will.

@divshacker
Copy link
Contributor Author

Hey @SooluThomas Sorry for responding Late, I was busy with college stuff.
I think I have fixed all as you have suggested.
Please have a look and let me know.
Thank You

@divshacker
Copy link
Contributor Author

Hey @SooluThomas I don't know how the test got Failed. Every thing looks Good to ne, Can you please try to fix that?
Thank You

@divshacker
Copy link
Contributor Author

Hey @nonhermitian Can you please Review this PR and let me know any changes needed.
Thank You

@divshacker
Copy link
Contributor Author

@nonhermitian

@divshacker
Copy link
Contributor Author

Hey @SooluThomas Can you please check this PR too.

@divshacker
Copy link
Contributor Author

Hey @SooluThomas @nonhermitian I don't know why it still not merging automatically. Can you restart the test as it will merge after successful completion of all test.

@SooluThomas SooluThomas merged commit 4c4c07d into Qiskit:master Mar 5, 2021
manoelmarques pushed a commit to manoelmarques/qiskit-nature that referenced this pull request Mar 11, 2021
Fixed some typos in "05_Sampling_potential_energy_surface"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants