Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and fix on scroll #41

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Refactor and fix on scroll #41

wants to merge 11 commits into from

Commits on Mar 12, 2021

  1. Replace deprecated node-sass package

    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c3f48cd View commit details
    Browse the repository at this point in the history

  2. Use destructuring assignment

    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    8d8fcac View commit details
    Browse the repository at this point in the history

  3. Make addPixels and getOffsetBorderRadius static

    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    1589668 View commit details
    Browse the repository at this point in the history

  4. DRY code

    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    16dc6a1 View commit details
    Browse the repository at this point in the history

  5. Use class field declarations with arrow functions. 

    C.f. https://github.com/tc39/proposal-class-fields
    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    d0b0f46 View commit details
    Browse the repository at this point in the history

  6. DOMTokenList.remove() accepts multiple parameters

    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    096eac0 View commit details
    Browse the repository at this point in the history

  7. Move if-clause into the function.

    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    a57bc52 View commit details
    Browse the repository at this point in the history

  8. Replace comment by readable code

    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    61444c5 View commit details
    Browse the repository at this point in the history

  9. Add more tests for scroll event handlers

    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    27d6d09 View commit details
    Browse the repository at this point in the history

  10. Ensure scroll/resize handlers are only called when needed

    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    e168885 View commit details
    Browse the repository at this point in the history

  11. Add missing semi-colons

    @caillou
    caillou committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    59c441d View commit details
    Browse the repository at this point in the history