Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support a standard api for parsing media types #376

Merged
merged 10 commits into from
Oct 10, 2018
Merged

support a standard api for parsing media types #376

merged 10 commits into from
Oct 10, 2018

Conversation

mmerickel
Copy link
Member

No description provided.

digitalresistor
digitalresistor approved these changes Sep 24, 2018
View reviewed changes
src/webob/acceptparse.py Show resolved Hide resolved
@mmerickel
Copy link
Member Author

This is ready for review. I can remove the specificity stuff from AcceptOffer if desired... it's not used anywhere but isn't really hurting anything and the conceptual ordering is used in a lot of places. I chose to not add a separate PR for a bug fix with acceptable_offers where Accept: */* did not match a range-based offer.

@mmerickel mmerickel mentioned this pull request Oct 2, 2018
Merged
stevepiercy
stevepiercy reviewed Oct 2, 2018
View reviewed changes
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/webob/acceptparse.py Outdated Show resolved Hide resolved
@mmerickel
Merge branch 'fix-warnings' into accept-parse-offer
ab13441
@mmerickel
remove media range support for offers
d0d538f 
see the multitude of reasons in
Pylons/pyramid#3326

the short answer is that they are fundamentally broken in that media
ranges cannot properly match against any accept header with q=0 content
@mmerickel
Copy link
Member Author

mmerickel commented Oct 10, 2018 •
edited
Loading

This PR now incorporates #378 and removes media range support from parse_offer and subsequently acceptable_offers. I would recommend merging #378 first and then reviewing this PR afterward.

@digitalresistor digitalresistor merged commit 1fa8a4e into Pylons:master Oct 10, 2018
digitalresistor added a commit that referenced this pull request Oct 15, 2018
@digitalresistor
Backport pull request #376
70ab88b 
support a standard api for parsing media types
This was referenced Aug 14, 2024
Closed
Closed
Merged
Open
Merged
Open
Open
Open
Open
Open
Open
This was referenced Aug 14, 2024
Closed
Merged
Merged
Closed
Merged
Open
Open
Merged
Merged
Open
Closed
Merged
Open
Merged
Open
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
This was referenced Aug 23, 2024
Open
Merged
This was referenced Sep 9, 2024
Open
Merged
Open
@dependabot dependabot bot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy left review comments

@digitalresistor digitalresistor digitalresistor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmerickel @stevepiercy @digitalresistor