Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Multiple inheritance in basics.rst #362

Merged
merged 1 commit into from
May 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/basics.rst
Original file line number Diff line number Diff line change
Expand Up @@ -773,11 +773,11 @@ Here's what's printed when the above is run:
.. code-block:: text

[(<colander.SchemaNode object at 14868560 (named a)>,
<colander.String object at 0xe25f90>),
(<colander.SchemaNode object at 14868816 (named b)>,
<colander.Boolean object at 0xe2e110>),
(<colander.SchemaNode object at 14868688 (named c)>,
<colander.String object at 0xe2e090>),
<colander.Integer object at 0xe25f90>),
(<colander.SchemaNode object at 14868816 (named c)>,
<colander.String object at 0xe2e110>),
(<colander.SchemaNode object at 14868688 (named b)>,
<colander.Boolean object at 0xe2e090>),
(<colander.SchemaNode object at 14868944 (named d)>,
<colander.Boolean object at 0xe2e190>)]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add an explanatory comment that the order of the children in the output is governed by Python's __mro__, e.g.

Suggested change
.. note::
The order of the children in the output above might seem suprising:
it is governed by how Python's multiple-inheritance works (the
``__mro__`` order).

Expand Down
Loading