New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create table test driven for message_transfer_cookbook_test #943

Merged

faddat merged 2 commits into Pylons-tech:main from lehieuhust:update-test/message_transfer_cookbook_test

Sep 1, 2022

Contributor

lehieuhust commented Aug 31, 2022

What is the purpose of the change

Write table-driven test code

Brief Changelog

Write all cli test cases with table-driven test for ValidateBasic function

Testing and Verifying

This change is a trivial rework/code cleanup without any test coverage

Documentation and Release Note

Does this pull request introduces a new feature or user-facing behaviour changes? no
How is the feature or change documented? not applicable


          create table test driven for message_transfer_cookbook_test

d26b517

lehieuhust requested review from faddat, mustafapylons, MikeSofaer and faisalnaveedRNS as code owners

August 31, 2022 09:47

mustafapylons approved these changes

View reviewed changes

mustafapylons left a comment

Looks good to me.

faddat approved these changes

View reviewed changes


          Merge branch 'main' into update-test/message_transfer_cookbook_test

898dff0

faddat merged commit 022d258 into Pylons-tech:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

faddat faddat approved these changes

mustafapylons mustafapylons approved these changes

MikeSofaer Awaiting requested review from MikeSofaer MikeSofaer is a code owner

faisalnaveedRNS Awaiting requested review from faisalnaveedRNS faisalnaveedRNS is a code owner

Labels

None yet