Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table test driven for query cookbook #911

Merged
merged 1 commit into from
Aug 30, 2022
Merged

table test driven for query cookbook #911

merged 1 commit into from
Aug 30, 2022

Conversation

ThanhNhann
Copy link
Contributor

What is the purpose of the change

  • Write table-driven test code

Brief Changelog

  • Write all cli test cases with table-driven test for CmdShowCookbook function

Testing and Verifying

  • This change is a trivial rework/code cleanup without any test coverage

Documentation and Release Note

  • Does this pull request introduces a new feature or user-facing behaviour changes? no
  • How is the feature or change documented? not applicable

Notional-labs

mustafapylons
mustafapylons approved these changes Aug 29, 2022
View reviewed changes
Copy link

@mustafapylons mustafapylons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@faddat faddat merged commit 3038461 into main Aug 30, 2022
@faddat faddat deleted the update-test/query_cookbook branch August 30, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faddat faddat faddat approved these changes

@mustafapylons mustafapylons mustafapylons approved these changes

@MikeSofaer MikeSofaer Awaiting requested review from MikeSofaer MikeSofaer is a code owner

@faisalnaveedRNS faisalnaveedRNS Awaiting requested review from faisalnaveedRNS faisalnaveedRNS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThanhNhann @faddat @mustafapylons